From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B2A3C1F9E0 for ; Wed, 29 Apr 2020 10:43:34 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] mid: capitalize "ID" in "Message-ID" Date: Wed, 29 Apr 2020 10:43:34 +0000 Message-Id: <20200429104334.24562-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Prefer the "ID" capitalization since it seems to to be the preferred capitalization in RFC 5322. In theory, this allows the interpreter to deduplicate the string internally (I haven't checked if it does). Unfortunately, there's too many instances of "Message-Id" in the tests to be worth changing at this point. --- lib/PublicInbox/Import.pm | 2 +- lib/PublicInbox/MID.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index 95d654f6..de8ff55f 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -354,7 +354,7 @@ sub v1_mid0 ($) { my $hdr = $mime->header_obj; my $mids = mids($hdr); - if (!scalar(@$mids)) { # spam often has no Message-Id + if (!scalar(@$mids)) { # spam often has no Message-ID my $mid0 = digest2mid(content_digest($mime), $hdr); append_mid($hdr, $mid0); return $mid0; diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm index dddde092..685306db 100644 --- a/lib/PublicInbox/MID.pm +++ b/lib/PublicInbox/MID.pm @@ -72,7 +72,7 @@ sub extract_mids { sub mids ($) { my ($hdr) = @_; - my @mids = $hdr->header_raw('Message-Id'); + my @mids = $hdr->header_raw('Message-ID'); uniq_mids(extract_mids(@mids)); } @@ -81,7 +81,7 @@ sub mids ($) { # import and index without relying on HTTP endpoints sub mids_for_index ($) { my ($hdr) = @_; - my @mids = $hdr->header_raw('Message-Id'); + my @mids = $hdr->header_raw('Message-ID'); my @alts = $hdr->header_raw('X-Alt-Message-ID'); uniq_mids(extract_mids(@mids, @alts)); }