From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/2] watchmaildir: match List-ID case-insensitively
Date: Thu, 23 Apr 2020 08:34:19 +0000 [thread overview]
Message-ID: <20200423083419.835-3-e@yhbt.net> (raw)
In-Reply-To: <20200423083419.835-1-e@yhbt.net>
RFC 2919 section 6 states the following:
There is only one operation defined for list identifiers,
that of case insensitive equality.
So no arguing with that. Now, the other headers are
open to interpretation, so put a note about them.
---
lib/PublicInbox/WatchMaildir.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 02e4b32f..71bd84fc 100644
--- a/lib/PublicInbox/WatchMaildir.pm
+++ b/lib/PublicInbox/WatchMaildir.pm
@@ -62,12 +62,17 @@ sub new {
if (my $whs = $ibx->{watchheader}) {
for (@$whs) {
my ($k, $v) = split(/:/, $_, 2);
+ # XXX should this be case-insensitive?
+ # Or, mutt-style, case-sensitive iff
+ # a capital letter exists?
push @$watch_hdrs, [ $k, qr/\Q$v\E/ ];
}
}
if (my $list_ids = $ibx->{listid}) {
for (@$list_ids) {
- my $re = qr/<[ \t]*\Q$_\E[ \t]*>/;
+ # RFC2919 section 6 stipulates
+ # "case insensitive equality"
+ my $re = qr/<[ \t]*\Q$_\E[ \t]*>/i;
push @$watch_hdrs, ['List-Id', $re ];
}
}
next prev parent reply other threads:[~2020-04-23 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 8:34 [RFC 0/2] watch behavior changes aNd ProPoSaL Eric Wong
2020-04-23 8:34 ` [PATCH 1/2] watchmaildir: scan all matching headers Eric Wong
2020-04-23 8:34 ` Eric Wong [this message]
2020-04-24 3:12 ` [RFC 0/2] watch behavior changes aNd ProPoSaL Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423083419.835-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).