From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 3FAA11F45A;
	Fri, 17 Apr 2020 09:33:31 +0000 (UTC)
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: [PATCH] qspawn: remove Perl 5.16.x leak workaround
Date: Fri, 17 Apr 2020 09:33:31 +0000
Message-Id: <20200417093331.25756-1-e@yhbt.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

It seems no longer necessary to workaround this Perl 5.16.3 bug
after the removal of anonymous subs from all of our internal
code in
https://public-inbox.org/meta/20191225075104.22184-1-e@80x24.org/

Tested with repeated clones (both aborted and completed)
in a CentOS 7.x VM which was once able to reproduce leaks
before the workaround appeared in 2fc42236f72ad16a
("qspawn: workaround Perl 5.16.3 leak, re-enable Deflater")

Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
---
 Oops, I intended to send this out shortly after 1.3.0 back in
 Feb; but forgot about the VM it was on after a power outage.

 lib/PublicInbox/Qspawn.pm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index aebcb1f7..c09e8d2c 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -281,10 +281,6 @@ sub psgi_return_init_cb {
 					${$self->{hdr_buf}}, $filter);
 		$wcb->($r);
 	}
-
-	# Workaround a leak under Perl 5.16.3 when combined with
-	# Plack::Middleware::Deflater:
-	$wcb = undef;
 }
 
 sub psgi_return_start { # may run later, much later...