From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 8BF121F5AD
	for <meta@public-inbox.org>; Mon,  6 Apr 2020 23:16:27 +0000 (UTC)
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] xt/perf-msgview: update to use git->cat_async
Date: Mon,  6 Apr 2020 23:16:27 +0000
Message-Id: <20200406231627.21428-1-e@yhbt.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

It's about 5-10% faster on an SMP machine with an SSD,
even on a hot Linux page cache.
---
 xt/perf-msgview.t | 26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t
index 3ea92ec6..a4445959 100644
--- a/xt/perf-msgview.t
+++ b/xt/perf-msgview.t
@@ -32,22 +32,30 @@ my $ctx = {
 	-inbox => $ibx,
 	www => Plack::Util::inline_object(style => sub {''}),
 };
-my ($str, $mime, $res, $cmt, $type);
+my ($mime, $res, $oid, $type);
 my $n = 0;
+my $obuf = '';
+my $m = 0;
+
+my $cb = sub {
+	$mime = PublicInbox::MIME->new(shift);
+	PublicInbox::View::multipart_text_as_html($mime, $ctx);
+	++$m;
+	$obuf = '';
+};
+
+$git->cat_async_begin;
 my $t = timeit(1, sub {
-	my $obuf = '';
 	$ctx->{obuf} = \$obuf;
 	$ctx->{mhref} = '../';
 	while (<$fh>) {
-		($cmt, $type) = split / /;
+		($oid, $type) = split / /;
 		next if $type ne 'blob';
 		++$n;
-		$str = $git->cat_file($cmt);
-		$mime = PublicInbox::MIME->new($str);
-		PublicInbox::View::multipart_text_as_html($mime, $ctx);
-		$obuf = '';
+		$git->cat_async($oid, $cb);
 	}
+	$git->cat_async_wait;
 });
-diag 'multipart_text_as_html took '.timestr($t)." for $n messages";
-ok 1;
+diag 'multipart_text_as_html took '.timestr($t)." for $n <=> $m messages";
+is($m, $n, 'rendered all messages');
 done_testing();