From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9CF3D1F619 for ; Sat, 7 Mar 2020 10:57:02 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] searchmsg: allow lines (and bytes) to be zero Date: Sat, 7 Mar 2020 10:57:02 +0000 Message-Id: <20200307105702.21268-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We will occasionally see legit messages with zero lines, be sure we index that count for NNTP clients. I'm not sure about bytes being zero (aside from purged messages), but we should've dealt with that earlier up the stack. --- lib/PublicInbox/SearchMsg.pm | 4 ++-- t/v2mirror.t | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index 42384936..84fe4802 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -42,8 +42,8 @@ sub to_doc_data { $self->cc, $oid, $mid0, - $self->{bytes} || '', - $self->{lines} || '' + $self->{bytes} // '', + $self->{lines} // '' ); } diff --git a/t/v2mirror.t b/t/v2mirror.t index dc930d90..2e23e763 100644 --- a/t/v2mirror.t +++ b/t/v2mirror.t @@ -55,6 +55,11 @@ for my $i (1..9) { my $epoch_max = $v2w->{epoch_max}; ok($epoch_max > 0, "multiple epochs"); $v2w->done; +{ + my $smsg = $ibx->over->get_art(1); + like($smsg->{lines}, qr/\A[0-9]+\z/, 'lines is a digit'); + like($smsg->{bytes}, qr/\A[0-9]+\z/, 'bytes is a digit'); +} $ibx->cleanup; my $sock = tcp_server();