user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] spawn: correctly handle error code
@ 2020-03-03  9:50 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-03-03  9:50 UTC (permalink / raw)
  To: meta

Both the C and pure Perl implementions of `pi_fork_exec'
returns `-1' on error, not `undef'.
---
 lib/PublicInbox/Spawn.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 2d9f734c..ad6be187 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -210,7 +210,7 @@ sub spawn ($;$$) {
 	}
 	my $cd = $opts->{'-C'} // ''; # undef => NULL mapping doesn't work?
 	my $pid = pi_fork_exec($redir, $f, $cmd, \@env, $rlim, $cd);
-	die "fork_exec failed: $!\n" unless defined $pid;
+	die "fork_exec failed: $!\n" unless $pid > 0;
 	$pid;
 }
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-03  9:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03  9:50 [PATCH] spawn: correctly handle error code Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).