user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: Leah Neukirchen <leah@vuxu.org>
Cc: meta@public-inbox.org, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: [pushed] msgtime: assume +0000 if TZ missing when using Date::Parse
Date: Sun, 1 Mar 2020 23:31:38 +0000	[thread overview]
Message-ID: <20200301233138.GA25934@dcvr> (raw)
In-Reply-To: <20200225092303.GA382@dcvr>

Eric Wong <e@yhbt.net> wrote:
> Leah Neukirchen <leah@vuxu.org> wrote:
> > 1) RFC5322/822 invalid Date: headers should be parsed more gracefully
> >
> > Some old mails had Date: headers without time zones, e.g.
> > Date: Sat, 27 Sep 1997 10:02:32
> >
> > This results in public-inbox asserting this is the current date.
> > But this assumption makes no sense (literally every other guess
> > would be more likely), and also results in these messages showing up
> > on the first page of the archive.  Furthermore, sorting is then not
> > stable, pressing F5 make the threads jump around.  I'd recommend
> > falling back to +0000 instead.
>
> I think a fallback to +0000 makes sense, too.
> It's not a new bug in 1.3.0 (which makes Date::Parse optional).
>
> Looks like that regression was introduced a while ago in
> commit ae80a3fdb53d70142624f2691ed8ed84eddda66b
> ("MsgTime.pm: Use strptime to compute the time zone")
>
> Cc-ing Eric W. Biederman in case he has any input on this.

> ------------8<------------
> Subject: [RFC] msgtime: assume +0000 if TZ missing when using Date::Parse

Pushed as commit d857e7dc0d816b635a7ead09c3273f8c2d2434be
with a more descriptive commit message:

    msgtime: assume +0000 if TZ missing when using Date::Parse

    Some old emails don't have timezone offsets, since our
    Date::Parse code path takes a liberal interpretation of dates,
    fallback to using "+0000" as the timezone offset since it's
    closer to the actual date of the message than whatever the
    current date is.

    Reported-by: Leah Neukirchen <leah@vuxu.org>
    Link: https://public-inbox.org/meta/87h7zfemur.fsf@vuxu.org/
    Fixes: ae80a3fdb53d7014 ("MsgTime.pm: Use strptime to compute the time zone")

Thanks

  reply	other threads:[~2020-03-01 23:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 20:45 Two small issues when importing old archives Leah Neukirchen
2020-02-25  9:23 ` [RFC] msgtime: do not require tz offset with Date::Parse fallback Eric Wong
2020-03-01 23:31   ` Eric Wong [this message]
2020-02-25  9:28 ` weird From: lines [was: Two small issues when importing old archives] Eric Wong
2020-02-26 10:21   ` [PATCH] import: drop '<' and '>' characters in addresses Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200301233138.GA25934@dcvr \
    --to=e@yhbt.net \
    --cc=ebiederm@xmission.com \
    --cc=leah@vuxu.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).