From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C87301F490 for ; Sat, 15 Feb 2020 09:46:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 6/8] view: escape Subject HTML directly Date: Sat, 15 Feb 2020 09:46:38 +0000 Message-Id: <20200215094640.19425-7-e@yhbt.net> In-Reply-To: <20200215094640.19425-1-e@yhbt.net> References: <20200215094640.19425-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: No need to use the over-engineered Hval OO API when the subject is already normalized and there's no trailing spaces because of normalization. --- lib/PublicInbox/View.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 033a0c14..d4bfa62d 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -1090,7 +1090,7 @@ sub dump_topics { my $mid = delete $seen->{$top_subj}; my $href = mid_escape($mid); my $prev_subj = [ split(/ /, $top_subj) ]; - $top_subj = PublicInbox::Hval->new($top_subj)->as_html; + $top_subj = ascii_html($top_subj); $ds = fmt_ts($ds); # $n isn't the total number of posts on the topic,