From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 36D411F48D for ; Sat, 15 Feb 2020 09:46:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/8] view: dump_topics: better naming of top Subject Date: Sat, 15 Feb 2020 09:46:35 +0000 Message-Id: <20200215094640.19425-4-e@yhbt.net> In-Reply-To: <20200215094640.19425-1-e@yhbt.net> References: <20200215094640.19425-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We use `$top' in other places, so name it to `$top_subj' consistently for `$subj' and `$prev_subj' comparisons down the function. --- lib/PublicInbox/View.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 45c191db..f0446723 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -1087,13 +1087,13 @@ sub dump_topics { # sort by recency, this allows new posts to "bump" old topics... foreach my $topic (sort { $b->[0] <=> $a->[0] } @$order) { - my ($ds, $n, $seen, $top, @ex) = @$topic; + my ($ds, $n, $seen, $top_subj, @ex) = @$topic; @$topic = (); - next unless defined $top; # ghost topic - my $mid = delete $seen->{$top}; + next unless defined $top_subj; # ghost topic + my $mid = delete $seen->{$top_subj}; my $href = mid_escape($mid); - my $prev_subj = [ split(/ /, $top) ]; - $top = PublicInbox::Hval->new($top)->as_html; + my $prev_subj = [ split(/ /, $top_subj) ]; + $top_subj = PublicInbox::Hval->new($top_subj)->as_html; $ds = fmt_ts($ds); # $n isn't the total number of posts on the topic, @@ -1109,7 +1109,7 @@ sub dump_topics { my $mbox = qq(mbox.gz); my $atom = qq(Atom); - my $s = "$top\n" . + my $s = "$top_subj\n" . " $ds UTC $n - $mbox / $atom\n"; for (my $i = 0; $i < scalar(@ex); $i += 2) { my $level = $ex[$i];