user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH] t/multi-mid: don't access ~/.public-inbox/config
Date: Thu,  6 Feb 2020 09:18:37 +0000	[thread overview]
Message-ID: <20200206091837.4957-1-e@yhbt.net> (raw)

It can cause unpredictable behavior and also slow things down.

Followup-to: e4d3be19612b2082 ("t: localize the PI_CONFIG env")
---
 t/multi-mid.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/multi-mid.t b/t/multi-mid.t
index 0d283a0d..94c0e0a2 100644
--- a/t/multi-mid.t
+++ b/t/multi-mid.t
@@ -48,8 +48,8 @@ for my $order ([$bad, $good], [$good, $bad]) {
 	}
 	my $rdr = { 1 => \(my $out = ''), 2 => \(my $err = '') };
 	my $cmd = [ '-convert', $ibx->{inboxdir}, "$tmpdir/v2" ];
-	ok(run_script($cmd, undef, $rdr),
-		'convert to v2');
+	my $env = { PI_DIR => "$tmpdir/.public-inbox" };
+	ok(run_script($cmd, $env, $rdr), 'convert to v2');
 	$err =~ s!\AW: $tmpdir/v1 not configured[^\n]+\n!!s;
 	is($err, '', 'no errors or warnings from -convert');
 	$ibx->{version} = 2;

                 reply	other threads:[~2020-02-06  9:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206091837.4957-1-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).