From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 01D9C1F881 for ; Tue, 4 Feb 2020 04:44:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 4/5] inbox: remove TODO item for msg_by_path Date: Tue, 4 Feb 2020 04:44:24 +0000 Message-Id: <20200204044425.14031-5-e@yhbt.net> In-Reply-To: <20200204044425.14031-1-e@yhbt.net> References: <20200204044425.14031-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's an old function which only gets called by inboxes w/o SQLite indices. --- lib/PublicInbox/Inbox.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index accfd974..a5849a61 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -305,9 +305,9 @@ sub nntp_usable { $ret; } +# for v1 users w/o SQLite only sub msg_by_path ($$;$) { my ($self, $path, $ref) = @_; - # TODO: allow other refs: my $str = git($self)->cat_file('HEAD:'.$path, $ref); $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s if $str; $str;