From: Eric Wong <e@yhbt.net> To: meta@public-inbox.org Subject: [PATCH 13/22] xt/perf-msgview: switch to multipart_text_as_html Date: Sat, 25 Jan 2020 04:45:01 +0000 Message-ID: <20200125044510.13769-14-e@yhbt.net> (raw) In-Reply-To: <20200125044510.13769-1-e@yhbt.net> It's a more widely-used (but still internal) API which will probably last longer than msg_html. It also reaches deeper into the stack and avoids the overhead of ->getline via PSGI, so it's faster and gives a more accurate measurement of lower-level parts. --- xt/perf-msgview.t | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t index 8c9037ee..9375977a 100644 --- a/xt/perf-msgview.t +++ b/xt/perf-msgview.t @@ -35,18 +35,18 @@ my $ctx = { my ($str, $mime, $res, $cmt, $type); my $n = 0; my $t = timeit(1, sub { + my $obuf = ''; + $ctx->{obuf} = \$obuf; while (<$fh>) { ($cmt, $type) = split / /; next if $type ne 'blob'; ++$n; $str = $git->cat_file($cmt); $mime = PublicInbox::MIME->new($str); - $res = PublicInbox::View::msg_html($ctx, $mime); - $res = $res->[2]; - while (defined($res->getline)) {} - $res->close; + PublicInbox::View::multipart_text_as_html($mime, '../', $ctx); + $obuf = ''; } }); -diag 'msg_html took '.timestr($t)." for $n messages"; +diag 'multipart_text_as_html took '.timestr($t)." for $n messages"; ok 1; done_testing();
next prev parent reply other threads:[~2020-01-25 4:45 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-25 4:44 [PATCH 00/22] HTML display cleanups, fixes, speedups Eric Wong 2020-01-25 4:44 ` [PATCH 01/22] www*stream: favor \&close instead of *close Eric Wong 2020-01-25 4:44 ` [PATCH 02/22] www: use "skel" terminology consistently Eric Wong 2020-01-25 4:44 ` [PATCH 03/22] view: improve readability around walk_thread Eric Wong 2020-01-25 4:44 ` [PATCH 04/22] searchview: keep $noop sub private to the package Eric Wong 2020-01-25 4:44 ` [PATCH 05/22] view: reduce parameters for html_footer Eric Wong 2020-01-25 4:44 ` [PATCH 06/22] view: thread_skel: drop constant tpfx parameter Eric Wong 2020-01-25 4:44 ` [PATCH 07/22] view: simplify duplicate Message-ID handling Eric Wong 2020-01-25 4:44 ` [PATCH 08/22] wwwstream: discard single-use $ctx fields after use Eric Wong 2020-01-25 4:44 ` [PATCH 09/22] view: start performing buffering into {obuf} Eric Wong 2020-01-25 4:44 ` [PATCH 10/22] t/plack.t: modernize and unindent Eric Wong 2020-01-25 4:44 ` [PATCH 11/22] init: use Import::run_die instead of system() Eric Wong 2020-01-25 4:45 ` [PATCH 12/22] tests: move the majority of t/view.t into t/plack.t Eric Wong 2020-01-25 4:45 ` Eric Wong [this message] 2020-01-25 4:45 ` [PATCH 14/22] view: inline and eliminate msg_html Eric Wong 2020-01-25 4:45 ` [PATCH 15/22] linkify: compile $LINK_RE once Eric Wong 2020-01-25 4:45 ` [PATCH 16/22] linkify: move to_html over from ViewDiff Eric Wong 2020-01-25 4:45 ` [PATCH 17/22] searchidx: skip filenames on "diff --git ..." Eric Wong 2020-01-25 4:45 ` [PATCH 18/22] searchidx: don't assume "a/" and "b/" as prefixes Eric Wong 2020-01-25 4:45 ` [PATCH 19/22] viewdiff: add "b=" param with non-standard diff prefix Eric Wong 2020-01-25 4:45 ` [PATCH 20/22] viewdiff: add "b=" param when missing "diff --git" line Eric Wong 2020-01-25 4:45 ` [PATCH 21/22] viewdiff: use autovivification for long_path hash Eric Wong 2020-01-25 4:45 ` [PATCH 22/22] viewdiff: rewrite and simplify Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200125044510.13769-14-e@yhbt.net \ --to=e@yhbt.net \ --cc=meta@public-inbox.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
user/dev discussion of public-inbox itself This inbox may be cloned and mirrored by anyone: git clone --mirror http://public-inbox.org/meta git clone --mirror http://czquwvybam4bgbro.onion/meta git clone --mirror http://hjrcffqmbrq6wope.onion/meta git clone --mirror http://ou63pmih66umazou.onion/meta # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 meta meta/ http://public-inbox.org/meta \ meta@public-inbox.org public-inbox-index meta Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta nntp://news.gmane.io/gmane.mail.public-inbox.general note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/public-inbox.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git