From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 940AD1F884 for ; Sun, 19 Jan 2020 09:40:52 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/2] hval: from_attr: move to unit test Date: Sun, 19 Jan 2020 09:40:52 +0000 Message-Id: <20200119094052.11772-3-e@yhbt.net> In-Reply-To: <20200119094052.11772-1-e@yhbt.net> References: <20200119094052.11772-1-e@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We don't call from_attr anywhere outside of tests, so don't bloat normal processes with it. --- lib/PublicInbox/Hval.pm | 15 +-------------- t/hval.t | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm index 39256ee0..2589c519 100644 --- a/lib/PublicInbox/Hval.pm +++ b/lib/PublicInbox/Hval.pm @@ -10,7 +10,7 @@ use Encode qw(find_encoding); use PublicInbox::MID qw/mid_clean mid_escape/; use base qw/Exporter/; our @EXPORT_OK = qw/ascii_html obfuscate_addrs to_filename src_escape - to_attr from_attr prurl/; + to_attr prurl/; my $enc_ascii = find_encoding('us-ascii'); # safe-ish acceptable filename pattern for portability @@ -148,17 +148,4 @@ sub to_attr ($) { $first . $str; } -# reverse the result of to_attr -sub from_attr ($) { - my ($str) = @_; - my $first = ''; - if ($str =~ s/\AZ([a-f0-9]{2})//ms) { - $first = chr(hex($1)); - } - $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms; - $str =~ tr!:!/!; - utf8::decode($str); - $first . $str; -} - 1; diff --git a/t/hval.t b/t/hval.t index f93d6be6..53f52f07 100644 --- a/t/hval.t +++ b/t/hval.t @@ -3,7 +3,20 @@ use strict; use warnings; use Test::More; -use_ok 'PublicInbox::Hval', qw(from_attr to_attr); +use_ok 'PublicInbox::Hval', qw(to_attr); + +# reverse the result of to_attr +sub from_attr ($) { + my ($str) = @_; + my $first = ''; + if ($str =~ s/\AZ([a-f0-9]{2})//ms) { + $first = chr(hex($1)); + } + $str =~ s!::([a-f0-9]{2})!chr(hex($1))!egms; + $str =~ tr!:!/!; + utf8::decode($str); + $first . $str; +} my $ibx = { -no_obfuscate_re => qr/(?:example\.com)\z/i,