user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 0/3] improve error handling for rare cases
Date: Thu,  9 Jan 2020 11:14:49 +0000
Message-ID: <20200109111452.14556-1-e@yhbt.net> (raw)

I tend to configure high RLIMIT_NOFILE limits, and the default
/proc/sys/fs/epoll/max_user_watches is difficult to hit, so
I've never hit the errors these patches supposedly fix...

But, I've noticed there's a places were we could die() without
an eval{} to trap it.  These patches fix some of those.

On a side note, we still lack sufficient testing for rare error
conditions.  These errors are not easy to reproduce, especially
EPOLL_CTL_ADD failures.

Also, the IO::KQueue->EV_SET calls actually make calls to
kqueue(2) directly (working more like epoll_ctl), so those could
die() inside the emulated epoll_ctl... Another day

Eric Wong (3):
  listener: EPOLL_CTL_ADD errors are non fatal
  http: log response_write errors
  qspawn: catch transient errors on pipe, EPOLL_CTL_ADD

 lib/PublicInbox/HTTP.pm     |  5 ++++-
 lib/PublicInbox/Listener.pm |  3 ++-
 lib/PublicInbox/Qspawn.pm   | 29 ++++++++++++++++++-----------
 3 files changed, 24 insertions(+), 13 deletions(-)

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 11:14 Eric Wong [this message]
2020-01-09 11:14 ` [PATCH 1/3] listener: EPOLL_CTL_ADD errors are non fatal Eric Wong
2020-01-09 11:14 ` [PATCH 2/3] http: log response_write errors Eric Wong
2020-01-09 11:14 ` [PATCH 3/3] qspawn: catch transient errors on pipe, EPOLL_CTL_ADD Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200109111452.14556-1-e@yhbt.net \
    --to=e@yhbt.net \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git