From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 0/3] improve error handling for rare cases
Date: Thu, 9 Jan 2020 11:14:49 +0000 [thread overview]
Message-ID: <20200109111452.14556-1-e@yhbt.net> (raw)
I tend to configure high RLIMIT_NOFILE limits, and the default
/proc/sys/fs/epoll/max_user_watches is difficult to hit, so
I've never hit the errors these patches supposedly fix...
But, I've noticed there's a places were we could die() without
an eval{} to trap it. These patches fix some of those.
On a side note, we still lack sufficient testing for rare error
conditions. These errors are not easy to reproduce, especially
EPOLL_CTL_ADD failures.
Also, the IO::KQueue->EV_SET calls actually make calls to
kqueue(2) directly (working more like epoll_ctl), so those could
die() inside the emulated epoll_ctl... Another day
Eric Wong (3):
listener: EPOLL_CTL_ADD errors are non fatal
http: log response_write errors
qspawn: catch transient errors on pipe, EPOLL_CTL_ADD
lib/PublicInbox/HTTP.pm | 5 ++++-
lib/PublicInbox/Listener.pm | 3 ++-
lib/PublicInbox/Qspawn.pm | 29 ++++++++++++++++++-----------
3 files changed, 24 insertions(+), 13 deletions(-)
next reply other threads:[~2020-01-09 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 11:14 Eric Wong [this message]
2020-01-09 11:14 ` [PATCH 1/3] listener: EPOLL_CTL_ADD errors are non fatal Eric Wong
2020-01-09 11:14 ` [PATCH 2/3] http: log response_write errors Eric Wong
2020-01-09 11:14 ` [PATCH 3/3] qspawn: catch transient errors on pipe, EPOLL_CTL_ADD Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109111452.14556-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).