user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH] build: allow "check" to work in non-git subdirs of worktrees
Date: Fri, 3 Jan 2020 01:50:14 +0000	[thread overview]
Message-ID: <20200103015014.GA29655@dcvr> (raw)
In-Reply-To: <20200102232928.17407-1-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> --- a/Makefile.PL
> +++ b/Makefile.PL
> @@ -167,13 +167,14 @@ changed = \$(shell git ls-files -m)
>  dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
>  
>  check-manifest :: MANIFEST
> -	if git ls-files >\$?.gen 2>&1; then diff -u \$? \$?.gen; fi
> +	if test -e .git && git ls-files >\$?.gen 2>&1; then \
> +		diff -u \$? \$?.gen; fi

Oops, forgot to escape the trailing slash :x
(I'm probably still traumatized from the solver regexp :x)

diff --git a/Makefile.PL b/Makefile.PL
index c7c661e8..b8c05cf7 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -167,7 +167,7 @@ changed = \$(shell git ls-files -m)
 dsyn :: \$(addsuffix .syntax, \$(filter \$(changed), \$(syn_files)))
 
 check-manifest :: MANIFEST
-	if test -e .git && git ls-files >\$?.gen 2>&1; then \
+	if test -e .git && git ls-files >\$?.gen 2>&1; then \\
 		diff -u \$? \$?.gen; fi
 
 # the traditional way running per-*.t processes:

      reply	other threads:[~2020-01-03  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 23:29 [PATCH] build: allow "check" to work in non-git subdirs of worktrees Eric Wong
2020-01-03  1:50 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103015014.GA29655@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).