From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B03AB1F47A for ; Tue, 31 Dec 2019 10:30:13 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/5] githttpbackend: remove ancient compatibility check Date: Tue, 31 Dec 2019 10:30:11 +0000 Message-Id: <20191231103013.9133-4-e@80x24.org> In-Reply-To: <20191231103013.9133-1-e@80x24.org> References: <20191231103013.9133-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The ref() call could be hitting memory leaks on Perl 5.16.x. It's been 3 years (2016-12-25) since 292ca34140489da2 ("githttpbackend: simplify compatibility code") back when this project was barely known and probably nobody used examples/public-inbox.psgi... --- lib/PublicInbox/GitHTTPBackend.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm index 8dd27a75..8883ec34 100644 --- a/lib/PublicInbox/GitHTTPBackend.pm +++ b/lib/PublicInbox/GitHTTPBackend.pm @@ -47,9 +47,6 @@ sub r ($;$) { sub serve { my ($env, $git, $path) = @_; - # XXX compatibility... ugh, can we stop supporting this? - $git = PublicInbox::Git->new($git) unless ref($git); - # Documentation/technical/http-protocol.txt in git.git # requires one and exactly one query parameter: if ($env->{QUERY_STRING} =~ /\Aservice=git-[A-Za-z0-9_]+-pack\z/ ||