user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] t/edit.t: drop redundant "delete local $ENV{...}"
@ 2019-12-16  8:07 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-12-16  8:07 UTC (permalink / raw)
  To: meta

"delete local" is only in Perl v5.11.0, and we only depend on
Perl v5.10.1.  We already localize and delete it as two separate
statements immediately above.

I wish this was hidden behind a "use feature" flag like other
new-fangled things :<.  Oh well, I think the oldest Perl actually
in use for this project is 5.16 (CentOS 7.x).
---
 t/edit.t | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/edit.t b/t/edit.t
index 02df6cda..122aa19f 100644
--- a/t/edit.t
+++ b/t/edit.t
@@ -129,7 +129,6 @@ $t = 'mailEditor set in config'; {
 	is($rc, 0, 'set publicinbox.mailEditor');
 	local $ENV{MAIL_EDITOR};
 	delete $ENV{MAIL_EDITOR};
-	delete local $ENV{MAIL_EDITOR};
 	local $ENV{GIT_EDITOR} = 'echo should not run';
 	$cmd = [ '-edit', "-m$mid", $inboxdir ];
 	ok(run_script($cmd, undef, $opt), "$t edited message");

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-12-16  8:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16  8:07 [PATCH] t/edit.t: drop redundant "delete local $ENV{...}" Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).