user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/7] t: localize the PI_CONFIG env
Date: Fri, 29 Nov 2019 10:14:08 +0000
Message-ID: <20191129101414.343-2-e@80x24.org> (raw)
In-Reply-To: <20191129101414.343-1-e@80x24.org>

We don't want the user's ~/.public-inbox/config to be read from
during tests.  I only noticed this because I had a non-existent
pathname for one of my inboxes :x

I've also verified this change by running "inotifywait
~/.public-inbox/config -m" in another terminal while running
"make check"; (perhaps a portable solution could make it
into the test suite).
---
 t/indexlevels-mirror.t | 1 +
 t/xcpdb-reshard.t      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/t/indexlevels-mirror.t b/t/indexlevels-mirror.t
index f1c338e1..3d4813be 100644
--- a/t/indexlevels-mirror.t
+++ b/t/indexlevels-mirror.t
@@ -32,6 +32,7 @@ sub import_index_incremental {
 	my ($v, $level) = @_;
 	my $this = "pi-$v-$level-indexlevels";
 	my ($tmpdir, $for_destroy) = tmpdir();
+	local $ENV{PI_CONFIG} = "$tmpdir/config";
 	my $ibx = PublicInbox::Inbox->new({
 		inboxdir => "$tmpdir/testbox",
 		name => $this,
diff --git a/t/xcpdb-reshard.t b/t/xcpdb-reshard.t
index ebf156a3..a4ab35d6 100644
--- a/t/xcpdb-reshard.t
+++ b/t/xcpdb-reshard.t
@@ -25,6 +25,7 @@ my $mime = PublicInbox::MIME->create(
 
 my ($this) = (split('/', $0))[-1];
 my ($tmpdir, $for_destroy) = tmpdir();
+local $ENV{PI_CONFIG} = "$tmpdir/config";
 my $ibx = PublicInbox::Inbox->new({
 	inboxdir => "$tmpdir/testbox",
 	name => $this,

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 10:14 [PATCH 0/7] some low impact changes and cleanups Eric Wong
2019-11-29 10:14 ` Eric Wong [this message]
2019-11-29 10:14 ` [PATCH 2/7] t/common: set $0 when running script w/o fork Eric Wong
2019-11-29 10:14 ` [PATCH 3/7] ds: ->Reset initializes $nextq Eric Wong
2019-11-29 10:14 ` [PATCH 4/7] TODO: update and add a few more items Eric Wong
2019-11-29 10:14 ` [PATCH 5/7] tests: don't repeatly validate NEWS.atom Eric Wong
2019-11-29 10:14 ` [PATCH 6/7] spawn: remove support for clearing the env Eric Wong
2019-11-29 10:14 ` [PATCH 7/7] import: (cleanup) drop redundant env arg to run_die Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191129101414.343-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git