[PATCH 0/2] replace: quiet down git commands

[PATCH 0/2] replace: quiet down git commands

[Eric Wong]

git fsck and gc are noisier when not run under "prove",
as git will decide to emit progress depending on whether
or not stderr is a TTY (prove makes stderr a pipe).

Eric Wong (2):
  t/replace: quiet "git fsck" invocation
  replace: quiet "git gc" invocation

 lib/PublicInbox/Import.pm     | 2 +-
 lib/PublicInbox/V2Writable.pm | 2 +-
 t/replace.t                   | 5 +++--
 3 files changed, 5 insertions(+), 4 deletions(-)

[PATCH 1/2] t/replace: quiet "git fsck" invocation

[Eric Wong]

Test output can be a terminal if running as "perl -I lib t/$FOO.t",
and showing fsck progress is pointless for tests.
---
 t/replace.t | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/t/replace.t b/t/replace.t
index e9361856..57290f96 100644
--- a/t/replace.t
+++ b/t/replace.t
@@ -99,8 +99,9 @@ EOF
 
 	for my $dir (glob("$ibx->{inboxdir}/git/*.git")) {
 		my ($bn) = ($dir =~ m!([^/]+)\z!);
-		is(system(qw(git --git-dir), $dir, qw(fsck --strict)), 0,
-			"git fsck is clean in epoch $bn");
+		is(system(qw(git --git-dir), $dir,
+					qw(fsck --strict --no-progress)),
+			0, "git fsck is clean in epoch $bn");
 	}
 
 	my $thread_b = $ibx->over->get_thread('replace@example.com');

[PATCH 2/2] replace: quiet "git gc" invocation

[Eric Wong]

Since we give users no indication or control of how "git gc"
runs, showing its progress is confusing.
---
 lib/PublicInbox/Import.pm     | 2 +-
 lib/PublicInbox/V2Writable.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index cb25215d..8a369ee4 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -595,7 +595,7 @@ sub replace_oids {
 
 	return if $nreplace == 0;
 
-	run_die([@git, qw(-c gc.reflogExpire=now gc --prune=all)]);
+	run_die([@git, qw(-c gc.reflogExpire=now gc --prune=all --quiet)]);
 
 	# check that old OIDs are gone
 	my $err = 0;
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 02f313b0..ab80941a 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -1204,7 +1204,7 @@ sub unindex ($$$$) {
 
 	# ensure any blob can not longer be accessed via dumb HTTP
 	PublicInbox::Import::run_die(['git', "--git-dir=$git->{git_dir}",
-		qw(-c gc.reflogExpire=now gc --prune=all)]);
+		qw(-c gc.reflogExpire=now gc --prune=all --quiet)]);
 }
 
 sub sync_ranges ($$$) {