user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/httpd-unix: FreeBSD expects to fail with EADDRINUSE
Date: Thu, 28 Nov 2019 07:08:54 +0000	[thread overview]
Message-ID: <20191128070854.1451-1-e@80x24.org> (raw)

Tested FreeBSD 11.2.  I'm starting to think I'm too conservative
with this check and it could be safely expanded to cover any OS
with UNIX sockets.
---
 t/httpd-unix.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/httpd-unix.t b/t/httpd-unix.t
index f7881cfa..ceec127c 100644
--- a/t/httpd-unix.t
+++ b/t/httpd-unix.t
@@ -59,7 +59,7 @@ sub check_sock ($) {
 check_sock($unix);
 
 { # do not clobber existing socket
-	my %err = ( 'linux' => EADDRINUSE );
+	my %err = ( 'linux' => EADDRINUSE, 'freebsd' => EADDRINUSE );
 	open my $out, '>>', "$tmpdir/1" or die "redirect failed: $!";
 	open my $err, '>>', "$tmpdir/2" or die "redirect failed: $!";
 	my $cmd = ['-httpd', '-l', $unix, '-W0', $psgi];

                 reply	other threads:[~2019-11-28  7:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128070854.1451-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).