user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: meta@public-inbox.org
Subject: Re: message threading in the web UI
Date: Fri, 15 Nov 2019 23:52:35 +0000	[thread overview]
Message-ID: <20191115235235.GA17044@dcvr> (raw)
In-Reply-To: <20191115212814.GB32365@maple.netwinder.org>

Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
> The way that threads are displayed seems to differ between the "frontpage"
> (eg. https://public-inbox.org/meta/) versus how they are shown in the
> "Thread Overview" (at the bottom of the page when viewing a specific
> thread).
> 
> On the frontpage, it seems only a subset of messages are displayed (maybe
> only the direct replies?). The only indication that there are additional
> hidden messages is the "+" sign, e.g. "(5+ messages)".

Yes, the frontpage only grabs the 200 most recent messages
(a "time window").

> In contrast when viewing a message thread, the "Thread Overview" at the
> bottom shows quite clearly the full thread (nothing seems to be hidden).

Right.  That's a separate SQLite query for every thread.

> Would it be possible to either:
> * unify the behaviour so it is the same in all places, or
> * in the "frontpage" make it more clear that threads are hidden,
>  for example change "(5+ messages)" to "N/M messages". Consider adding
>  a link ("rest of thread" or "additional replies") as a final element
>  for any "abbreviated" threads.
> 
> One might argue that "+" sign is sufficient indicator, but until you realize
> its significance, it is just noise. When I first saw it, I manually counted
> the messages, and compared that with "(5+ messages"). They nearly matched,
> so I assumed the "+" indicated that an exact value was not possible, for
> whatever reason.

Getting the exact value is possible, just more expensive...

> Anyhow, this is just my $0.02, but I though I'd pass it along.

Thanks for the feedback; and I agree, it's sometimes confusing :x

Getting the full count ("M") can be expensive since it needs an
SQLite COUNT query for every thread...

I'm not sure how feasable that is since frontpage performance is
critical and I spent a fair amount of time making it perform
acceptably for giant inboxes like LKML.

(Optionally) supporting Cache::FastMmap or other caching
mechanisms may help, but that's still extra install overhead and
initial load performance still needs to be taken into account.

Perhaps as an interim solution is to change the "+" for
something more obvious:

"5 or more messages"
"5 messages in current time window"
">= 5 messages"
"at least 5 messages"
...

Thoughts?

  reply	other threads:[~2019-11-15 23:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 21:28 message threading in the web UI Ralph Siemsen
2019-11-15 23:52 ` Eric Wong [this message]
2019-11-16 14:40   ` Ralph Siemsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115235235.GA17044@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --cc=ralph.siemsen@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).