user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/4] t/common: inline stream_to_string into t/feed.t
Date: Thu, 14 Nov 2019 06:41:11 +0000	[thread overview]
Message-ID: <20191114064114.9763-2-e@80x24.org> (raw)
In-Reply-To: <20191114064114.9763-1-e@80x24.org>

We only use it in one place and have favored test_psgi
in newer tests, so move it out-of-the-way to reduce startup
overhead of other *.t files.
---
 t/common.perl | 11 -----------
 t/feed.t      |  9 ++++++++-
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/t/common.perl b/t/common.perl
index ccc7be46..053a935a 100644
--- a/t/common.perl
+++ b/t/common.perl
@@ -7,17 +7,6 @@ use strict;
 use warnings;
 use IO::Socket::INET;
 
-sub stream_to_string {
-	my ($res) = @_;
-	my $body = $res->[2];
-	my $str = '';
-	while (defined(my $chunk = $body->getline)) {
-		$str .= $chunk;
-	}
-	$body->close;
-	$str;
-}
-
 sub tcp_server () {
 	IO::Socket::INET->new(
 		LocalAddr => '127.0.0.1',
diff --git a/t/feed.t b/t/feed.t
index eb1f35fb..93da3717 100644
--- a/t/feed.t
+++ b/t/feed.t
@@ -14,7 +14,14 @@ my $have_xml_feed = eval { require XML::Feed; 1 };
 require './t/common.perl';
 
 sub string_feed {
-	stream_to_string(PublicInbox::Feed::generate($_[0]));
+	my $res = PublicInbox::Feed::generate($_[0]);
+	my $body = $res->[2];
+	my $str = '';
+	while (defined(my $chunk = $body->getline)) {
+		$str .= $chunk;
+	}
+	$body->close;
+	$str;
 }
 
 my $tmpdir = tempdir('pi-feed-XXXXXX', TMPDIR => 1, CLEANUP => 1);

  reply	other threads:[~2019-11-14  6:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14  6:41 [PATCH 0/4] some minor test updates Eric Wong
2019-11-14  6:41 ` Eric Wong [this message]
2019-11-14  6:41 ` [PATCH 2/4] t/common: move unix_server to t/httpd-corner.t Eric Wong
2019-11-14  6:41 ` [PATCH 3/4] t/psgi_mount: require SearchIdx before using Eric Wong
2019-11-14  6:41 ` [PATCH 4/4] doc: check-man: save the result of successful runs Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191114064114.9763-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).