user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] t/httpd-corner.t: check for curl(1) errors in big async test
@ 2019-11-04  2:27 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-11-04  2:27 UTC (permalink / raw)
  To: meta

curl(1) can fail and we need to invalidate the test in the
rare case it fails.
---
 t/httpd-corner.t | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/httpd-corner.t b/t/httpd-corner.t
index 4077a6d1..fbba4623 100644
--- a/t/httpd-corner.t
+++ b/t/httpd-corner.t
@@ -272,6 +272,7 @@ SKIP: {
 		$n += $r;
 		$buf =~ /\A\0+\z/ or $non_zero++;
 	}
+	close $fh or die "curl errored out \$?=$?";
 	is($n, 30 * 1024 * 1024, 'got expected output from curl');
 	is($non_zero, 0, 'read all zeros');
 }
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-11-04  2:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04  2:27 [PATCH] t/httpd-corner.t: check for curl(1) errors in big async test Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).