From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 80A801F4BD; Thu, 10 Oct 2019 08:51:18 +0000 (UTC) Date: Thu, 10 Oct 2019 08:51:18 +0000 From: Eric Wong To: Alyssa Ross Cc: meta@public-inbox.org Subject: Re: [PATCH] doc: explain publicinbox..watchheader Message-ID: <20191010085118.r3amey4cayazfycb@dcvr> References: <20191009132113.29255-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191009132113.29255-1-hi@alyssa.is> List-Id: Alyssa Ross wrote: > It wasn't clear to me exactly what this does -- in particular, what > happens if it isn't specified? Does it support multiple values? A > very brief explanation can answer both of these questions without > making somebody look at the code. Thanks, applied and pushed. > --- > The part about it not supporting multiple values is my best guess > based on a quick glance at the code -- I may well have missed > something. That's correct. I think a single value here is fine. If it supported multiple values, it would be confusing as to whether it needs to match all the headers, or if matching any one header would put it into an inbox. And I also question the need for either case...