From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] TODO: add item for searching based on git-patch-id(1)
Date: Tue, 1 Oct 2019 22:00:02 +0000 [thread overview]
Message-ID: <20191001220002.GA21797@dcvr> (raw)
In-Reply-To: <20191001210009.GA4232@pure.paranoia.local>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Tue, Oct 01, 2019 at 03:37:47AM +0000, Eric Wong wrote:
> > +* support searching based on `git-patch-id --stable` to improve
> > + bidirectional mapping of commits <=> emails
>
> It would be handy, but a word of caution -- because it strips
> whitespace, git-patch-id is not great for languages with syntactic
> indentation, like Python. For example, the following two patches
> generate the same patch-id, but one is actually malicious:
Good point. Makefiles also fall into that category, I wonder
what other languages are whitespace sensitive?
<snip>
> So, I wouldn't use git-patch-id as a mechanism to look up patches,
> except as an auxiliary one.
It's usable for 99% of patches for the kernel, though. But
right, dfpost:$BLOB_ID matches should take precedence, and we
can use a lower weight for the patch-id in Xapian
The bigger question is the cost in time to reindex...
And ultimately, I wonder if dfpost:$BLOB_ID + s:$COMMIT_TITLE
is good enough, too... I think I need to dig out something
I abandoned years ago for indexing coderepos and refactor that
to be less space-intensive now.
prev parent reply other threads:[~2019-10-01 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 3:37 [PATCH] TODO: add item for searching based on git-patch-id(1) Eric Wong
2019-10-01 21:00 ` Konstantin Ryabitsev
2019-10-01 22:00 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001220002.GA21797@dcvr \
--to=e@80x24.org \
--cc=konstantin@linuxfoundation.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).