From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D464E1F464; Thu, 26 Sep 2019 01:59:53 +0000 (UTC) Date: Thu, 26 Sep 2019 01:59:53 +0000 From: Eric Wong To: Alyssa Ross Cc: meta@public-inbox.org, Amitai Schleier Subject: Re: [PATCH] hlmod: update for highlight 3.51 API change Message-ID: <20190926015953.GA4445@dcvr> References: <20190924200551.31014-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190924200551.31014-1-hi@alyssa.is> List-Id: Alyssa Ross wrote: > Quoting Amitai Schleier, who made this same change in ikiwiki[1], > where lots of the public-inbox highlight code comes from: > > > As of 3.51, searchFile() is no longer provided in highlight's Perl > > bindings (at least on NetBSD and OS X, as built from pkgsrc). This > > leaves us falling through to getConfDir(), which has been gone > > rather longer. > > > > From highlight git, it appears searchFile() and getFiletypesConfPath() > > both originated in the 3.14 release. The latter is still available in > > 3.51, and returns the same result searchFile() used to. Switch to it. > > So, this should still be compatible with the version of highlight.pm in > Debian, but add support for newer versions as well. > > [1]: commit 4d06df9583e6c4145f8c6fc2fd51d7894c0b85ce Thanks both, pushed as dadaf7fd96301f1737b2eca2171a742daef8befd I had my reservations about relying on highlight.pm; and this confirms them, unfortunately :< Oh well... I wonder if pygments or any other code highlighting packages are more stable. We'd need to use a pipe or socket to interact with pygments or anything w/o Perl bindings.