Re: [PATCH] t/spawn: fix with unusual env locations

[Eric Wong <e@80x24.org>]

Alyssa Ross <hi@alyssa.is> wrote:
> >> The call to spawn clears the environment, including PATH.  This means
> >> that an env in a non-default location wouldn't be found, while all the
> >> other tests work because they use PATH.  We can fix this by looking up
> >> which PATH to use beforehand.
> >
> > Thanks for reporting this issue, but... is that it?
> > We also use spawn() for 'git', among other things...
> 
> Yes, I can confirm that this was the only failing test case in my build.

Thanks for confirming, pushed my patch as
4b3e278d9c4e5d1f55c1781aa0a7c9f0453f3852 to master.

In my original reply, I missed the test was using the "-env"
option to clear %ENV.  It's probably safe to drop the "-env"
option for spawn() to clear %ENV since we don't use it in real
code...

> (It may be of note however that I did not have Xapian enabled.  Trying
> to build with that caused a host of other failures that were beyond my
> ability to troubleshoot, so I decided to just give up on running the
> tests for now, since they seem very dependent on the environment and the
> environment inside our build sandboxes is so different from what
> public-inbox will have on a running system anyway.)

I don't know much about Nix, but I hope/expect public-inbox
tests to work on every reasonably modern Unix-like OS which
Perl5, git, and SQLite run on.

If you post logs of the failures you encountered, it would
improve the chances that somebody here (maybe not me) can
help fix them.  Thanks.