From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A4CE31F466 for ; Tue, 17 Sep 2019 08:31:23 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/6] qspawn: log errors for generic PSGI server users Date: Tue, 17 Sep 2019 08:31:19 +0000 Message-Id: <20190917083123.6468-3-e@80x24.org> In-Reply-To: <20190917083123.6468-1-e@80x24.org> References: <20190917083123.6468-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Generic PSGI servers have $env->{'psgi.errors'}, too, so ensure they can log errors. --- lib/PublicInbox/Qspawn.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index 6b350f0..844d50f 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -116,10 +116,9 @@ sub waitpid_err ($$) { sub do_waitpid ($;$) { my ($self, $env) = @_; my $pid = $self->{pid}; - eval { # PublicInbox::DS may not be loaded - PublicInbox::DS::dwaitpid($pid, \&waitpid_err, $self); - $self->{env} = $env; - }; + $self->{env} = $env; + # PublicInbox::DS may not be loaded + eval { PublicInbox::DS::dwaitpid($pid, \&waitpid_err, $self) }; # done if we're running in PublicInbox::DS::EventLoop if ($@) { # non public-inbox-{httpd,nntpd} callers may block: -- EW