* [PATCH] nntp: fix redundant CRLF from "LISTGROUP GROUP RANGE"
@ 2019-09-08 10:45 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-09-08 10:45 UTC (permalink / raw)
To: meta
Since Net::NNTP::listgroup doesn't support the range parameter,
I had to test this manually and noticed extra CRLF were emitted.
---
lib/PublicInbox/NNTP.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 7c3f68a..41f1e9c 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -237,7 +237,7 @@ sub cmd_listgroup ($;$$) {
long_response($self, sub {
$r = $mm->msg_range(\$beg, $end, 'num');
scalar(@$r) or return;
- more($self, join("\r\n", map { "$_->[0]\r\n" } @$r));
+ more($self, join("\r\n", map { $_->[0] } @$r));
1;
});
} else { # grab every article number
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-08 10:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-08 10:45 [PATCH] nntp: fix redundant CRLF from "LISTGROUP GROUP RANGE" Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).