From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 02C0B1F461 for ; Sun, 8 Sep 2019 10:45:15 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] nntp: fix redundant CRLF from "LISTGROUP GROUP RANGE" Date: Sun, 8 Sep 2019 10:45:14 +0000 Message-Id: <20190908104514.11523-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Since Net::NNTP::listgroup doesn't support the range parameter, I had to test this manually and noticed extra CRLF were emitted. --- lib/PublicInbox/NNTP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 7c3f68a..41f1e9c 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -237,7 +237,7 @@ sub cmd_listgroup ($;$$) { long_response($self, sub { $r = $mm->msg_range(\$beg, $end, 'num'); scalar(@$r) or return; - more($self, join("\r\n", map { "$_->[0]\r\n" } @$r)); + more($self, join("\r\n", map { $_->[0] } @$r)); 1; }); } else { # grab every article number -- EW