user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] nntp: fix redundant CRLF from "LISTGROUP GROUP RANGE"
@ 2019-09-08 10:45 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-09-08 10:45 UTC (permalink / raw)
  To: meta

Since Net::NNTP::listgroup doesn't support the range parameter,
I had to test this manually and noticed extra CRLF were emitted.
---
 lib/PublicInbox/NNTP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 7c3f68a..41f1e9c 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -237,7 +237,7 @@ sub cmd_listgroup ($;$$) {
 		long_response($self, sub {
 			$r = $mm->msg_range(\$beg, $end, 'num');
 			scalar(@$r) or return;
-			more($self, join("\r\n", map { "$_->[0]\r\n" } @$r));
+			more($self, join("\r\n", map { $_->[0] } @$r));
 			1;
 		});
 	} else { # grab every article number
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-08 10:45 [PATCH] nntp: fix redundant CRLF from "LISTGROUP GROUP RANGE" Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox