From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id C3DB61F461 for ; Sat, 13 Jul 2019 20:27:57 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] nntpdeflate: stop relying on SUPER for ->do_read Date: Sat, 13 Jul 2019 20:27:57 +0000 Message-Id: <20190713202757.16268-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We won't need further layering after enabling compression. So be explicit about which sub we're calling when we hit ->do_read from NNTP and eliminate the need for the comment. --- lib/PublicInbox/NNTPdeflate.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm index 10e2337c..f2de0f38 100644 --- a/lib/PublicInbox/NNTPdeflate.pm +++ b/lib/PublicInbox/NNTPdeflate.pm @@ -62,13 +62,13 @@ sub enable { # overrides PublicInbox::NNTP::compressed sub compressed { 1 } -# SUPER is PublicInbox::DS::do_read, so $_[1] may be a reference or not +# $_[1] may be a reference or not sub do_read ($$$$) { my ($self, $rbuf, $len, $off) = @_; my $zin = $self->{zin} or return; # closed my $deflated = \($zin->[1]); - my $r = $self->SUPER::do_read($deflated, $len) or return; + my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return; # assert(length($$rbuf) == $off) as far as NNTP.pm is concerned # -ConsumeInput is true, so $deflated is automatically emptied -- EW