user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] nntpdeflate: stop relying on SUPER for ->do_read
@ 2019-07-13 20:27 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-07-13 20:27 UTC (permalink / raw)
  To: meta

We won't need further layering after enabling compression.  So
be explicit about which sub we're calling when we hit ->do_read
from NNTP and eliminate the need for the comment.
---
 lib/PublicInbox/NNTPdeflate.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm
index 10e2337c..f2de0f38 100644
--- a/lib/PublicInbox/NNTPdeflate.pm
+++ b/lib/PublicInbox/NNTPdeflate.pm
@@ -62,13 +62,13 @@ sub enable {
 # overrides PublicInbox::NNTP::compressed
 sub compressed { 1 }
 
-# SUPER is PublicInbox::DS::do_read, so $_[1] may be a reference or not
+# $_[1] may be a reference or not
 sub do_read ($$$$) {
 	my ($self, $rbuf, $len, $off) = @_;
 
 	my $zin = $self->{zin} or return; # closed
 	my $deflated = \($zin->[1]);
-	my $r = $self->SUPER::do_read($deflated, $len) or return;
+	my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return;
 
 	# assert(length($$rbuf) == $off) as far as NNTP.pm is concerned
 	# -ConsumeInput is true, so $deflated is automatically emptied
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-13 20:27 [PATCH] nntpdeflate: stop relying on SUPER for ->do_read Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox