user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] httpd: (cleanup) use reference instead of *glob
Date: Mon,  8 Jul 2019 07:39:04 +0000	[thread overview]
Message-ID: <20190708073905.15757-3-e@80x24.org> (raw)
In-Reply-To: <20190708073905.15757-1-e@80x24.org>

*glob notation isn't always necessary, and there's
no need to disable 'once' warnings, this way.
---
 lib/PublicInbox/HTTPD.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/PublicInbox/HTTPD.pm b/lib/PublicInbox/HTTPD.pm
index b0bf94ad..d10ec51c 100644
--- a/lib/PublicInbox/HTTPD.pm
+++ b/lib/PublicInbox/HTTPD.pm
@@ -39,10 +39,7 @@ sub new {
 		# The rest of our PSGI code is generic, relying
 		# on "pull" model using "getline" to prevent
 		# over-buffering.
-		'pi-httpd.async' => do {
-			no warnings 'once';
-			*pi_httpd_async
-		},
+		'pi-httpd.async' => \&pi_httpd_async
 	);
 	bless {
 		app => $app,
-- 
EW


  parent reply	other threads:[~2019-07-08  7:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08  7:39 [PATCH 0/3] a few minor cleanups Eric Wong
2019-07-08  7:39 ` [PATCH 1/3] daemon: use POSIX and WNOHANG more idiomatically Eric Wong
2019-07-08  7:39 ` Eric Wong [this message]
2019-07-08  7:39 ` [PATCH 3/3] http|nntp: "use PublicInbox::DS" instead of ->import Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708073905.15757-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).