user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] http: use MSG_MORE for identity callback, too
@ 2019-07-08  4:53 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-07-08  4:53 UTC (permalink / raw)
  To: meta

No point in using ->write to flush data out to a client
when the chunked callback also uses MSG_MORE to reduce
packets.
---
 lib/PublicInbox/HTTP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 5546ac46..1bd65331 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -237,7 +237,7 @@ sub chunked_wcb ($) {
 
 sub identity_wcb ($) {
 	my ($self) = @_;
-	sub { $self->write(\($_[0])) if $_[0] ne '' }
+	sub { msg_more($self, $_[0]) if $_[0] ne '' }
 }
 
 sub next_request ($) {
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08  4:53 [PATCH] http: use MSG_MORE for identity callback, too Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox