Re: [PATCH] viewdiff: do not anchor using diffstat comments

["SZEDER Gábor" <szeder.dev@gmail.com>]

On Fri, Jul 05, 2019 at 04:06:18AM +0000, Eric Wong wrote:
> Eric Wong <e@80x24.org> wrote:
> > SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > >   https://public-inbox.org/git/20190624130226.17293-2-pclouds@gmail.com/
> 
> Btw, I'm not sure if the "(new +x)" and all the surrounding
> spaces should be clickable.  I have poor coordination, so when I
> (rarely) use a mouse I prefer bigger targets to click; but maybe
> it can get confusing...

FWIW, I didn't find it odd or surprising that the "(new +x)" is part
of the link, and its color clearly indicates that it is part of the
link.

I haven't yet noticed that all the spaces following the filename are
clickable as well, because they don't look like part of the link
(well, being spaces, they don't have any color...), and haven't
noticed the cursor changing shape when hovering over them.

I'm not so sure about this, and think that it can be
confusing/undesired in some circumstances.  A user can click on any
"inactive" part of the browser window (i.e. what isn't a link, a
button, or any active GUI widget) to focus and raise the window
without any other effects, so they might just happen to click on
those unsuspicious spaces because they don't look like a link, and
then be surprised when the page jumps to corresponding diff.