From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/httpd-unix.t: avoid race in between bind() and listen()
Date: Sun, 30 Jun 2019 22:32:32 +0000 [thread overview]
Message-ID: <20190630223232.73227-1-e@80x24.org> (raw)
We need to be able to successfully connect() to the socket
before attempting further tests. Merely testing for the
existence of a socket isn't enough, since the server may've
only done bind(), not listen().
---
t/httpd-unix.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/httpd-unix.t b/t/httpd-unix.t
index db652479..4fe2d1eb 100644
--- a/t/httpd-unix.t
+++ b/t/httpd-unix.t
@@ -42,8 +42,9 @@ my $spawn_httpd = sub {
ok(!-S $unix, 'UNIX socket does not exist, yet');
$spawn_httpd->("-l$unix");
+my %o = (Peer => $unix, Type => SOCK_STREAM);
for (1..1000) {
- last if -S $unix;
+ last if -S $unix && IO::Socket::UNIX->new(%o);
select undef, undef, undef, 0.02
}
--
EW
reply other threads:[~2019-06-30 22:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190630223232.73227-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).