From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8FB681F461 for ; Sun, 30 Jun 2019 22:19:39 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/2] warn on inheriting blocking sockets Date: Sun, 30 Jun 2019 22:19:37 +0000 Message-Id: <20190630221939.9885-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: A followup to https://public-inbox.org/meta/20190630074146.GA16199@dcvr/ ("examples/*@.service: sockets MUST be NonBlocking") 1/2 is a long-needed cleanup patch, 2/2 is what matters to users. Yeah, I'm shocked it's taken as long as it has to notice this oversight, I completely missed that systemd would clear O_NONBLOCK before spawning new instances. I kinda wish accept4 would take SOCK_DONTWAIT (and maybe SOCK_MUSTWAIT), but I also don't want to bloat the kernel even more. Eric Wong (2): tests: common tcp_server and unix_server helpers daemon: warn on inheriting blocking listeners lib/PublicInbox/Daemon.pm | 10 +++++++++- lib/PublicInbox/Listener.pm | 1 - t/common.perl | 21 +++++++++++++++++++++ t/git-http-backend.t | 9 +-------- t/httpd-corner.t | 15 ++------------- t/httpd-https.t | 9 +-------- t/httpd.t | 10 +--------- t/nntpd-tls.t | 11 ++--------- t/nntpd.t | 10 ++-------- t/perf-nntpd.t | 9 +-------- t/v2mirror.t | 8 +------- t/v2writable.t | 9 +-------- t/www_listing.t | 9 +-------- 13 files changed, 43 insertions(+), 88 deletions(-) -- EW