From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 92F461F461 for ; Sun, 30 Jun 2019 00:16:59 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] t/nntpd*.t: skip TLS tests for old Net::NNTP Date: Sun, 30 Jun 2019 00:16:59 +0000 Message-Id: <20190630001659.4431-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Perl prior to 5.22 did not bundle a Net::NNTP (or libnet) capable of handling TLS. --- t/nntpd-tls.t | 3 +++ t/nntpd.t | 9 +++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t index 427d370f..e3ecdd4f 100644 --- a/t/nntpd-tls.t +++ b/t/nntpd-tls.t @@ -11,6 +11,9 @@ foreach my $mod (qw(DBD::SQLite IO::Socket::SSL Net::NNTP IO::Poll)) { eval "require $mod"; plan skip_all => "$mod missing for $0" if $@; } +Net::NNTP->can('starttls') or + plan skip_all => 'Net::NNTP does not support TLS'; + my $cert = 'certs/server-cert.pem'; my $key = 'certs/server-key.pem'; unless (-r $key && -r $cert) { diff --git a/t/nntpd.t b/t/nntpd.t index 6cba2be4..bf5bb883 100644 --- a/t/nntpd.t +++ b/t/nntpd.t @@ -106,8 +106,13 @@ EOF is_deeply($list, { $group => [ qw(1 1 n) ] }, 'LIST works'); is_deeply([$n->group($group)], [ qw(0 1 1), $group ], 'GROUP works'); is_deeply($n->listgroup($group), [1], 'listgroup OK'); - ok(!$n->starttls, 'STARTTLS fails when unconfigured'); - is($n->code, 580, 'got 580 code on server w/o TLS'); + + SKIP: { + $n->can('starttls') or + skip('Net::NNTP too old to support STARTTLS', 2); + ok(!$n->starttls, 'STARTTLS fails when unconfigured'); + is($n->code, 580, 'got 580 code on server w/o TLS'); + }; %opts = ( PeerAddr => $host_port, -- EW