From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/ds-leak: fix race
Date: Sat, 29 Jun 2019 07:18:53 +0000 [thread overview]
Message-ID: <20190629071853.21833-1-e@80x24.org> (raw)
We need to ensure we run lsof on the sleep(1) process, and not
the fork of ourselves before execve(2). This race applies when
we're using the default pure-Perl spawn() implementation.
---
t/ds-leak.t | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/t/ds-leak.t b/t/ds-leak.t
index dd8446dc..34ffc125 100644
--- a/t/ds-leak.t
+++ b/t/ds-leak.t
@@ -15,9 +15,21 @@ if ('close-on-exec for epoll and kqueue') {
PublicInbox::DS->SetLoopTimeout(0);
PublicInbox::DS->SetPostLoopCallback(sub { 0 });
+
+ # make sure execve closes if we're using fork()
+ my ($r, $w);
+ pipe($r, $w) or die "pipe: $!";
+
PublicInbox::DS->AddTimer(0, sub { $pid = spawn([qw(sleep 10)]) });
PublicInbox::DS->EventLoop;
ok($pid, 'subprocess spawned');
+
+ # wait for execve, we need to ensure lsof sees sleep(1)
+ # and not the fork of this process:
+ close $w or die "close: $!";
+ my $l = <$r>;
+ is($l, undef, 'cloexec works and sleep(1) is running');
+
my @of = grep(/$evfd_re/, `lsof -p $pid 2>/dev/null`);
my $err = $?;
SKIP: {
--
EW
reply other threads:[~2019-06-29 7:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629071853.21833-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).