user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/4] www|nntp: optimize uses of Email::Simple
Date: Thu, 27 Jun 2019 22:51:44 +0000	[thread overview]
Message-ID: <20190627225148.9657-1-e@80x24.org> (raw)

We can rely on the documented behavior of Email::Simple->new
modifying its string buffer in-place to save us the trouble
of calling ->body (or ->body_set('') to clobber the buffer).

This yields significant memory use improvements in avoiding full
message body copies in the WWW mbox code.  Unfortunately, NNTP
messages with LF-only line-endings won't benefit, since the
protocol requires CRLF endings and the s/// operations get
expensive.

Memory bloat from giant emails and Email::MIME will require
more work :<

Eric Wong (4):
  nntp: rework and simplify art_lookup response
  mbox: use Email::Simple->new to do in-place modifications
  mbox: split header and body processing
  nntp: reduce syscalls for ARTICLE and BODY

 lib/PublicInbox/Mbox.pm | 73 +++++++++++++++++++++--------------------
 lib/PublicInbox/NNTP.pm | 59 ++++++++++++++++-----------------
 2 files changed, 67 insertions(+), 65 deletions(-)

-- 
EW

             reply	other threads:[~2019-06-27 22:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 22:51 Eric Wong [this message]
2019-06-27 22:51 ` [PATCH 1/4] nntp: rework and simplify art_lookup response Eric Wong
2019-06-27 22:51 ` [PATCH 2/4] mbox: use Email::Simple->new to do in-place modifications Eric Wong
2019-06-27 22:51 ` [PATCH 3/4] mbox: split header and body processing Eric Wong
2019-06-27 22:51 ` [PATCH 4/4] nntp: reduce syscalls for ARTICLE and BODY Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627225148.9657-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).