From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] edit: fix portability of editor invocation
Date: Mon, 10 Jun 2019 23:53:46 +0000 [thread overview]
Message-ID: <20190610235346.64907-1-e@80x24.org> (raw)
The eval was unnecessary, and $0 can't be "--".
Tested with /bin/sh on FreeBSD 11.2
---
script/public-inbox-edit | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/script/public-inbox-edit b/script/public-inbox-edit
index 16d7852..6a7d456 100755
--- a/script/public-inbox-edit
+++ b/script/public-inbox-edit
@@ -138,7 +138,7 @@ foreach my $to_edit (values %$found) {
# run the editor, respecting spaces/quote
retry_edit:
- if (system(qw(sh -c), qq(eval "$editor" '"\$@"'), '--', $edit_fn)) {
+ if (system(qw(sh -c), $editor.' "$@"', $editor, $edit_fn)) {
if (!(-t STDIN) && !$opt->{force}) {
die "E: $editor failed: $?\n";
}
--
EW
reply other threads:[~2019-06-10 23:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610235346.64907-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).