user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <>
Subject: [PATCH] edit: fix portability of editor invocation
Date: Mon, 10 Jun 2019 23:53:46 +0000
Message-ID: <> (raw)

The eval was unnecessary, and $0 can't be "--".
Tested with /bin/sh on FreeBSD 11.2
 script/public-inbox-edit | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/public-inbox-edit b/script/public-inbox-edit
index 16d7852..6a7d456 100755
--- a/script/public-inbox-edit
+++ b/script/public-inbox-edit
@@ -138,7 +138,7 @@ foreach my $to_edit (values %$found) {
 	# run the editor, respecting spaces/quote
-	if (system(qw(sh -c), qq(eval "$editor" '"\$@"'), '--', $edit_fn)) {
+	if (system(qw(sh -c), $editor.' "$@"', $editor, $edit_fn)) {
 		if (!(-t STDIN) && !$opt->{force}) {
 			die "E: $editor failed: $?\n";

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone public-inbox