From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 56C9D1F462; Mon, 10 Jun 2019 15:40:58 +0000 (UTC) Date: Mon, 10 Jun 2019 15:40:58 +0000 From: Eric Wong To: Konstantin Ryabitsev Cc: meta@public-inbox.org Subject: Re: [PATCH 00/11] v2: implement message editing Message-ID: <20190610154058.jqaawkktvb5u2itj@dcvr> References: <20190609025147.24966-1-e@80x24.org> <20190610150647.GA16418@chatter.i7.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190610150647.GA16418@chatter.i7.local> List-Id: Konstantin Ryabitsev wrote: > Thanks, Eric. I'm testing this out now. Quick question -- I'm assuming this > can't be done online, while new messages are arriving, correct? Should the > procedure be to stop incoming mail, perform the edits, then start the mail > again? It is designed to be done online by flock-ing inbox.lock. All the write operations are protected by that lock; I use -learn all the time to remove spam and also used to --reindex frequently. For messages deeper into history, then it takes longer to replay subsequent history and blocks -mda/-watch messages for longer. I just noticed, the status message triggers a perl uninitialized warning with multiple epochs, but it's harmless. Will fix in a bit.