user/dev discussion of public-inbox itself
 help / color / mirror / Atom feed
From: Eric Wong <>
Subject: [PATCH 2/2] git: drop the deleted err_c file
Date: Sat,  1 Jun 2019 03:37:06 +0000
Message-ID: <> (raw)
In-Reply-To: <>

No reason to leave that (usually) empty file open after killing off
"cat-file --batch-check".  This wasn't an unbound leak, though,
as respawning the --batch-check process would've clobbered the
old err_c file.
 lib/PublicInbox/ | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 9a38d7c..9014e02 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -211,9 +211,10 @@ sub check {
 sub _destroy {
-	my ($self, $in, $out, $pid) = @_;
+	my ($self, $in, $out, $pid, $err) = @_;
 	my $p = delete $self->{$pid} or return;
 	delete @$self{($in, $out)};
+	delete $self->{$err} if $err; # `err_c'
 	waitpid $p, 0;
@@ -243,7 +244,7 @@ sub qx {
 sub cleanup {
 	my ($self) = @_;
 	_destroy($self, qw(in out pid));
-	_destroy($self, qw(in_c out_c pid_c));
+	_destroy($self, qw(in_c out_c pid_c err_c));
 	!!($self->{pid} || $self->{pid_c});

      parent reply	other threads:[~2019-06-01  3:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-01  3:37 [PATCH 0/2] git: a few minor cleanup tweaks to daemons Eric Wong
2019-06-01  3:37 ` [PATCH 1/2] git: unconditional expiry Eric Wong
2019-06-01  3:37 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 meta meta/ \
	public-inbox-index meta

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone