From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D155C1F462 for ; Fri, 31 May 2019 16:46:04 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] viewdiff: avoid repeat variable expansion Date: Fri, 31 May 2019 16:46:04 +0000 Message-Id: <20190531164604.12870-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: This is worth a 1-2% speedup in t/perf-msgview.t rendering 2620 messages currently in https://public-inbox.org/meta/ --- lib/PublicInbox/ViewDiff.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index 6b8d943..411ed2b 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -159,7 +159,7 @@ sub flush_diff ($$$) { $state == DSTATE_INIT or to_state($dst, $state, DSTATE_INIT); $$dst .= $s; - } elsif ($s =~ m!^diff --git ($PATH_A) ($PATH_B)$!) { + } elsif ($s =~ m!^diff --git ($PATH_A) ($PATH_B)$!o) { my ($pa, $pb) = ($1, $2); if ($state != DSTATE_HEAD) { to_state($dst, $state, DSTATE_HEAD); @@ -194,8 +194,8 @@ sub flush_diff ($$$) { $$dst .= ''; $state = DSTATE_CTX; $$dst .= to_html($linkify, $s); - } elsif ($s =~ m!^--- (?:$PATH_A)! || - $s =~ m!^\+{3} (?:$PATH_B)!) { + } elsif ($s =~ m!^--- (?:$PATH_A)!o || + $s =~ m!^\+{3} (?:$PATH_B)!o) { # color only (no oid link) if missing dctx->{oid_*} $state <= DSTATE_STAT and to_state($dst, $state, DSTATE_HEAD); -- EW