user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH 0/2] minor build/test tweaks
@ 2019-05-29  8:45 Eric Wong
  2019-05-29  8:45 ` [PATCH 1/2] Makefile.PL: allow `N' variable to be set in local config.mak Eric Wong
  2019-05-29  8:45 ` [PATCH 2/2] Makefile.PL: enable prove warnings Eric Wong
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Wong @ 2019-05-29  8:45 UTC (permalink / raw)
  To: meta

Eric Wong (2):
      Makefile.PL: allow `N' variable to be set in local config.mak
      Makefile.PL: enable prove warnings

 Makefile.PL | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] Makefile.PL: allow `N' variable to be set in local config.mak
  2019-05-29  8:45 [PATCH 0/2] minor build/test tweaks Eric Wong
@ 2019-05-29  8:45 ` Eric Wong
  2019-05-29  8:45 ` [PATCH 2/2] Makefile.PL: enable prove warnings Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2019-05-29  8:45 UTC (permalink / raw)
  To: meta

This can useful for limiting test resource use without relying
on remembering the variable command-line.
---
 Makefile.PL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.PL b/Makefile.PL
index de0c49f..f79697b 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -53,9 +53,9 @@ sub MY::postamble {
 # support using eatmydata to speed up tests (apt-get install eatmydata):
 # https://www.flamingspork.com/projects/libeatmydata/
 EATMYDATA =
+N = \$\$(( \$\$(nproc 2>/dev/null || gnproc 2>/dev/null || echo 2) + 1 ))
 -include config.mak
 -include Documentation/include.mk
-N = \$\$(( \$\$(nproc 2>/dev/null || gnproc 2>/dev/null || echo 2) + 1 ))
 SCRIPTS := scripts/ssoma-replay
 my_syntax := \$(addsuffix .syntax, $PM_FILES \$(EXE_FILES) \$(SCRIPTS))
 
-- 
EW


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] Makefile.PL: enable prove warnings
  2019-05-29  8:45 [PATCH 0/2] minor build/test tweaks Eric Wong
  2019-05-29  8:45 ` [PATCH 1/2] Makefile.PL: allow `N' variable to be set in local config.mak Eric Wong
@ 2019-05-29  8:45 ` Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2019-05-29  8:45 UTC (permalink / raw)
  To: meta

We already "use warnings" everywhere, but could miss some spots.
This ought to cover that, and usually Perl module authors are
consistent about avoiding warnings that we won't clutter our
test outputs.
---
 Makefile.PL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.PL b/Makefile.PL
index f79697b..b1274ad 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -69,7 +69,7 @@ check-manifest :: MANIFEST
 	if git ls-files >\$?.gen 2>&1; then diff -u \$? \$?.gen; fi
 
 check:: pure_all check-manifest
-	\$(EATMYDATA) prove -lv -j\$(N)
+	\$(EATMYDATA) prove -lvw -j\$(N)
 
 lib/PublicInbox/UserContent.pm :: contrib/css/216dark.css
 	\$(PERL) -I lib \$@ \$?
-- 
EW


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-29  8:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29  8:45 [PATCH 0/2] minor build/test tweaks Eric Wong
2019-05-29  8:45 ` [PATCH 1/2] Makefile.PL: allow `N' variable to be set in local config.mak Eric Wong
2019-05-29  8:45 ` [PATCH 2/2] Makefile.PL: enable prove warnings Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).