From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6D18E1F87F for ; Mon, 27 May 2019 18:45:46 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] searchidx: fix obvious typo Date: Mon, 27 May 2019 18:45:44 +0000 Message-Id: <20190527184545.536-3-e@80x24.org> In-Reply-To: <20190527184545.536-1-e@80x24.org> References: <20190527184545.536-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We can't pass an empty string to `git merge-base --is-ancestor' AFAIK, this did NOT present issues in the current test suite. --- lib/PublicInbox/SearchIdx.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 9c29106..b963805 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -694,7 +694,7 @@ sub _last_x_commit { $lx = $lm; } # Use last_commit from msgmap if it is older or unset - if (!$lm || ($lx && $lx && is_ancestor($self->{git}, $lm, $lx))) { + if (!$lm || ($lx && $lm && is_ancestor($self->{git}, $lm, $lx))) { $lx = $lm; } $lx; -- EW