From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 150701F462 for ; Mon, 27 May 2019 18:45:46 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/3] fix --reindex skipping NNTP article numbers Date: Mon, 27 May 2019 18:45:42 +0000 Message-Id: <20190527184545.536-1-e@80x24.org> In-Reply-To: <20190525195748.fguwama6byoxctoz@dcvr> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I was working on v2 cleanups and progress-reporting, and speeding up no-op 'public-inbox-index' invocations when I noticed --reindex showing higher-than-expected NNTP article numbers with the verbose output I'm working on. There's some (apparently) inconsequential typo fixes, too. I think the v1 --reindex code is alright, after all, but maybe I haven't been paying enough attention to it... Also, I've noticed the v1 indexing code works around a Xapian v1.2.20..v1.2.24 bug wrt OFD locks which the newer v2 code doesn't (since v2 was developed mainly on Xapian 1.4.3+). Not sure who uses Xapian 1.2, still; but it might still be worth fixing for folks on older systems. Eric Wong (3): t/v1reindex.t: fix typo in setting `indexlevel' searchidx: fix obvious typo v2: fix reindex skipping NNTP article numbers lib/PublicInbox/SearchIdx.pm | 2 +- lib/PublicInbox/V2Writable.pm | 25 ++++++++++++++++++++++++- t/indexlevels-mirror.t | 25 +++++++++++++++++++++++++ t/v1reindex.t | 2 +- 4 files changed, 51 insertions(+), 3 deletions(-) -- EW