user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/3] fix --reindex skipping NNTP article numbers
Date: Mon, 27 May 2019 18:45:42 +0000	[thread overview]
Message-ID: <20190527184545.536-1-e@80x24.org> (raw)
In-Reply-To: <20190525195748.fguwama6byoxctoz@dcvr>

I was working on v2 cleanups and progress-reporting,
and speeding up no-op 'public-inbox-index' invocations when
I noticed --reindex showing higher-than-expected NNTP
article numbers with the verbose output I'm working on.

There's some (apparently) inconsequential typo fixes, too.
I think the v1 --reindex code is alright, after all, but
maybe I haven't been paying enough attention to it...

Also, I've noticed the v1 indexing code works around a Xapian
v1.2.20..v1.2.24 bug wrt OFD locks which the newer v2 code
doesn't (since v2 was developed mainly on Xapian 1.4.3+).
Not sure who uses Xapian 1.2, still; but it might still be
worth fixing for folks on older systems.

Eric Wong (3):
  t/v1reindex.t: fix typo in setting `indexlevel'
  searchidx: fix obvious typo
  v2: fix reindex skipping NNTP article numbers

 lib/PublicInbox/SearchIdx.pm  |  2 +-
 lib/PublicInbox/V2Writable.pm | 25 ++++++++++++++++++++++++-
 t/indexlevels-mirror.t        | 25 +++++++++++++++++++++++++
 t/v1reindex.t                 |  2 +-
 4 files changed, 51 insertions(+), 3 deletions(-)

-- 
EW


  reply	other threads:[~2019-05-27 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25 19:57 --reindex buggy wrt NNTP numbers, fixes coming Eric Wong
2019-05-27 18:45 ` Eric Wong [this message]
2019-05-27 18:45   ` [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel' Eric Wong
2019-05-27 18:45   ` [PATCH 2/3] searchidx: fix obvious typo Eric Wong
2019-05-27 18:45   ` [PATCH 3/3] v2: fix reindex skipping NNTP article numbers Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527184545.536-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).