From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 7DAD01F462 for ; Sun, 26 May 2019 08:24:46 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] viewvcs: keep temporary Solver dir for large streams Date: Sun, 26 May 2019 08:24:46 +0000 Message-Id: <20190526082446.16148-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Streaming large blobs can take multiple iterations of the event loop in our -httpd; so we must not let the File::Temp::Dir result go out-of-scope when streaming large blobs created from patches. --- lib/PublicInbox/ViewVCS.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 962dc66..60a62e5 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -48,6 +48,7 @@ sub stream_large_blob ($$$$) { my $qsp = PublicInbox::Qspawn->new($cmd); my @cl = ('Content-Length', $size); my $env = $ctx->{env}; + $env->{'public-inbox.tmpgit'} = $git; # for {-tmp}/File::Temp::Dir $env->{'qspawn.wcb'} = delete $ctx->{-wcb}; $qsp->psgi_return($env, undef, sub { my ($r, $bref) = @_; -- EW